Add "Require conversation resolution before merging" to branch protection documentation #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, clean up some indentation to match the indentation displayed on the branch protection page in the GitHub web GUI.
dav3r
added
the
documentation
jsf9k
approved these changes
Aug 24, 2021
|
We should also add some jazz for disabling squash commits, which I suppose should go in a different Markdown file since that option is under the general settings instead of the branch protection settings. @dav3r, are you OK if I slip that into this PR? |
Sure, go for it! |
mcdonnnj
approved these changes
Aug 24, 2021
felddy
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR adds the "Require conversation resolution before merging" checkbox to our standard branch protection setup. It also adds a blurb about disabling squash merges. While I was here, I also cleaned up some indentation to match the indentation displayed on the branch protection page in the GitHub web GUI.
💭 Motivation and context
We want to ensure that our PRs are not merged before all conversations have been properly resolved.
🧪 Testing
Visual verification of Markdown changes.
✅ Checklist